Java Spring Rest and Swagger

I faced the problem related to Swagger and Java. My lecturer sent me a Swagger file from which I should create a REST API. Also, that REST API should export the same Swagger documentation as Lecturers.

In the Swagger definitions I found that there should be created 2 Models: Odd(object) and Bet(array). Everything is fine with the Odd Model, but I do not find a solution on how to create Bet array. If I simply create an ArrayList named Bet in the getOdd method and put all Odd objects inside, the model will not be created.

I was looking for solutions, but I did not succeed. Thank you in advance.

Lecturer Swagger file:

swagger: "2.0"
info:
  description: "Schema"
  version: "1.0.0"
  title: "API"
tags:
- name: "odds"
  description: "Offer and return Odds"
schemes:
- "http"
paths:
  /odds:
    post:
      tags:
      - "odds"
      summary: "Offer odds for a bet"
      consumes:
      - "application/json"
      produces:
      - "application/json"
      parameters:
      - in: "body"
        name: "body"
        description: "Odds that should be offered for a bet"
        required: true
        schema:
          $ref: "#/definitions/Odds"
      responses:
        201:
          description: "Odds have been created for bet"
        400:
          description: "Invalid format of Odds"
  /odds/{betId}:
    get:
      tags:
      - "odds"
      summary: "Find Odds by Bet ID"
      description: "Returns a list of odds for a given bet ID"
      produces:
      - "application/json"
      parameters:
      - name: "betId"
        in: "path"
        description: "ID of bet to return"
        required: true
        type: "integer"
        format: "int64"
      responses:
        200:
          description: "Odds are returned for bet ID"
          schema:
            $ref: "#/definitions/Bet"
        400:
          description: "Invalid Bet ID supplied"
        404:
          description: "Bet not found for given ID"
definitions:
  Odds:
    type: "object"
    properties:
      betId:
        type: "integer"
        format: "int64"
      userId:
        type: "string"
        description: "ID of user who is offering the odds"
      odds:
        type: "string"
        example: "1/10"
  **Bet:
    type: "array"
    items:
      $ref: '#/definitions/Odds'**

How Models should look like in Swagger

How getOdd method should look like in Swagger

I will paste some of my work done:

How my Models looks like in Swagger

How my getOdd method looks like in Swagger

My Rest Controller:

@RestController
@RequestMapping("/api")
public class OddController {

@Autowired 
OddRepository oddRepository;

@GetMapping("/odds/{betId}")
public Optional<Odd> getOdd(@PathVariable Long betId) {
		Optional<Odd> theOdd=oddRepository.findById(betId);
	return theOdd;
}

@PostMapping("/odds")
public Odd addOdd(@RequestBody Odd odd) {
	odd.setBetId((long) 0);
	oddRepository.save(odd);
	return odd;
}

My Odd class:

@Entity
@Table(name="odds")
@Data
public class Odd {

	@Id
	@GeneratedValue(strategy=GenerationType.IDENTITY)
	@Column(name="betid")
	private Long betId;

	@Column(name="userid")
	private String userId;
	
	@Column(name="odds")
	private String odds;
	 
}

You can use annotations to control the generation of the swagger definitions. There is a old and a new api to do that:

• Old:
  https://github.com/swagger-api/swagger-core/wiki/Annotations-1.5.X
• New:
  https://github.com/swagger-api/swagger-core/wiki/Swagger-2.X---Annotations

In the lecture swagger file 'swagger: "2.0"' is used. Therefore it would be the old one. The new one is producing swagger files for OpenApi 3.0.

Specially the annotation @ApiOperation and @ApiModelOperation could be interesting for you to solve your problem.

See also the JavaDoc:

• @ApiOperation: https://docs.swagger.io/swagger-core/v1.5.X/apidocs/index.html?io/swagger/annotations/ApiOperation.html
• @ApiModelProperty: https://docs.swagger.io/swagger-core/v1.5.X/apidocs/index.html?io/swagger/annotations/ApiModelProperty.html